This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Allow streaming cache invalidate all to workers.#6749
Merged
Conversation
anoadragon453
approved these changes
Jan 22, 2020
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
lgtm, just a q/clarification
|
|
||
| if cache_name == CURRENT_STATE_CACHE_NAME and keys is None: | ||
| raise Exception( | ||
| "Can't stream invalidate all with magic current state cache" |
Member
There was a problem hiding this comment.
As someone who hasn't completely wrapped his head around our caching yet, what does "magic" mean in this context?
Member
Author
There was a problem hiding this comment.
Hopefully the bottom of https://github.com/matrix-org/synapse/blob/master/docs/tcp_replication.md#cache-invalidation-stream should explain it a bit
erikjohnston
added a commit
that referenced
this pull request
Jan 22, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '5d7a6ad22': Allow streaming cache invalidate all to workers. (#6749)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.