This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Pass room_version into event_from_pdu_json#6856
Merged
Merged
Conversation
erikjohnston
approved these changes
Feb 6, 2020
| "Ignoring PDU for room %s with unknown version %s", | ||
| room_id, | ||
| room_version, | ||
| ) |
Member
There was a problem hiding this comment.
If we're logging it seems useful to include why we're ignoring an event?
Member
Author
There was a problem hiding this comment.
yes, but str(e) will tell us that.
Member
There was a problem hiding this comment.
But it won't log the room_id or the room version? (UnsupportedRoomVersionError doesn't include those things)
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Huh, ok then. (The uses I have seen don't specify a custom message)
richvdh
force-pushed
the
rav/redact_changes/6
branch
from
9fa55f4 to
85ee977
Compare
It's called from all over the shop, so this one's a bit messy.
richvdh
force-pushed
the
rav/redact_changes/6
branch
from
85ee977 to
928edef
Compare
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'e1b240329': Pass room_version into `event_from_pdu_json`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's called from all over the shop, so this one's a bit messy.
Based on #6823, #6854.