Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Allow moving group read APIs to workers#6866

Merged
erikjohnston merged 8 commits into
developfrom
erikj/create_group_worker_store
Feb 7, 2020
Merged

Allow moving group read APIs to workers#6866
erikjohnston merged 8 commits into
developfrom
erikj/create_group_worker_store

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

@erikjohnston erikjohnston commented Feb 6, 2020

Tests: matrix-org/sytest#798

Fixes #6415


Most of this PR is separating the various stores and handlers into what can be run on master and what can be run on workers, i.e. a bunch of cutting and pasting

@erikjohnston erikjohnston force-pushed the erikj/create_group_worker_store branch 2 times, most recently from ac07b27 to b685d81 Compare February 6, 2020 18:03
@erikjohnston erikjohnston requested a review from a team February 6, 2020 18:04
@erikjohnston erikjohnston force-pushed the erikj/create_group_worker_store branch from b685d81 to 75f3824 Compare February 6, 2020 18:06
Copy link
Copy Markdown
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume this won't break existing people's reverse-proxy configs?

@erikjohnston
Copy link
Copy Markdown
Member Author

You can still run groups on the master process happily, so its fine.

@erikjohnston erikjohnston merged commit de2d267 into develop Feb 7, 2020
@erikjohnston erikjohnston deleted the erikj/create_group_worker_store branch February 7, 2020 11:14
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'de2d26737':
  Allow moving group read APIs to workers (#6866)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants