Fix mounting of homeserver.yaml when it does not exist on host

[SuperSandro2000]

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
• Pull request includes a sign off
• Code style is correct (run the linters)

[richvdh]

it would be nice if your PR could say what you are trying to fix here, rather than just "update".

[SuperSandro2000]

I dropped the redundant patch and fixed the mount point by dropping it as we already have one on /data.

[richvdh]

I'm still a bit confused about what exactly we're trying to fix here. The subject says "Fix mounting of homeserver.yaml when it does not exist on host", but you can't run synapse without a config file, so this doesn't seem to make any sense?

[SuperSandro2000]

If you run docker-compose run --rm -e SYNAPSE_SERVER_NAME=my.matrix.host -e SYNAPSE_REPORT_STATS=yes synapse generate in contrib/docker and comment the duplicate traefik labels out you get:

tree -d
.
├── files
├── matrix-config
│   └── homeserver.yaml
└── schemas [error opening dir]

\ls matrix-config/ -l
total 4
drwxr-xr-x 2 root root 4096 Feb 27 15:44 homeserver.yaml

As you can see the homeserver.yaml is a directory and not a file cause the file did not exist when the container started to create it.

[richvdh]

right, you didn't mention that you were trying to use generate. seems sensible to me then.

[richvdh]

looks good.

Normally I'd request a changelog entry but since it's a relatively trivial change to a contrib example, I'm happy to skip it here.