Remove bind_email parameter from register_user

[anoadragon453]

As far as I can tell, this was only used by the bind_email parameter which was removed in #5964.

Emails added during registration still happen in post_registration_actions:

synapse/synapse/handlers/register.py

Lines 556 to 565 in 2d6d4fa

	if auth_result and LoginType.EMAIL_IDENTITY in auth_result:
	threepid = auth_result[LoginType.EMAIL_IDENTITY]
	# Necessary due to auth checks prior to the threepid being
	# written to the db
	if is_threepid_reserved(
	self.hs.config.mau_limits_reserved_threepids, threepid
	):
	yield self.store.upsert_monthly_active_user(user_id)
	yield self._register_email_threepid(user_id, threepid, access_token)

[clokep]

Looks OK. I think we need to think about changing the ModuleApi object a bit more?

[clokep]

We should probably note in the changelog that his changed (or leave it for backwards compatibility).

Do we know if any external modules called this with an iterable of emails?

[anoadragon453]

Aha! Good spot. Ok, I was under the impression that modules like matrix-synapse-ldap3 bound emails in another manner (through the check_3pid_auth module method).

But you're right!

Which probably makes this whole PR defunct I suppose.

[clokep]

Ah, yeah looks like this is still used then. :)

[anoadragon453]

Oh well!

[anoadragon453]

Closing as this argument is still used by modules. Your editor may not show it though as it won't know about a separate codebase's method calls :)