Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Ensure ReplicationStreamer is always started when replication enabled. #7579

Merged
erikjohnston merged 2 commits into from
May 27, 2020
Merged

Ensure ReplicationStreamer is always started when replication enabled. #7579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85363fd
Ensure ReplicationStreamer is always started when replication enabled.
erikjohnston May 27, 2020
365f2e2
Newsfile
erikjohnston May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/7579.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix bug where `ReplicationStreamer` was not always started when replication was enabled. Bug introduced in v1.14.0rc1.
3 changes: 3 additions & 0 deletions synapse/replication/tcp/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,9 @@ def start_replication(self, hs):
hs.config.redis_port,
)

# First let's ensure that we have a ReplicationStreamer started.
hs.get_replication_streamer()

# We need two connections to redis, one for the subscription stream and
# one to send commands to (as you can't send further redis commands to a
# connection after SUBSCRIBE is called).
Expand Down