This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Explain the purpose of the "tests" conditional dependency requirement#7751
Merged
Conversation
Member
|
I think in the past the assumption has been that tests get run with |
Member
Author
|
Hm, if that's the case we should probably place a comment in Edit: This PR has been updated to perform the above. |
anoadragon453
force-pushed
the
anoa/jwt_tests
branch
from
3af5917 to
a424d62
Compare
anoadragon453
changed the title
richvdh
reviewed
Jun 29, 2020
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
given that all implies test... what is the point of the test extra?
Member
|
Probably just to avoid magic in the calculation of the "all" requirement? |
Member
|
fair |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'dc80a0762': 1.16.0rc1 Back out MSC2625 implementation (#7761) Additional configuration options for auto-join rooms (#7763) Add some metrics for inbound and outbound federation processing times (#7755) Explain the purpose of the "tests" conditional dependency requirement (#7751) Add another yield point to state res v2 (#7746) Move flake8 to end. Don't exit script on failure (#7738) Make tox actions work on Debian 10 (#7703) Yield during large v2 state res. (#7735) add org.matrix.login.jwt so that m.login.jwt can be deprecated (#7675) Set Content-Length for Metrics requests (#7730) Sync ignored table names in synapse_port_db to current database schema (#7717) Allow local media to be marked as safe from being quarantined. (#7718) Convert directory handler to async/await (#7727) Speed up state res v2 across large state differences. (#7725)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jwt, provided the thepyjwtmodule, is required by our unit testssynapse/tests/rest/client/v1/test_login.py
Line 7 in 831b31e
This PR adds the module to the
testconditional requirement.This does mean that we have to change a version number in two places if we ever want to update
pyjwts minimum version. Is there a way to consolidate this? (I'm aware I could define a version string outside of theCONDITIONAL_REQUIREMENTSdict, but is there a better way?)EDIT: This PR has been updated to explain that
"test"is not supposed to be all of the modules necessary to run the unit tests, but rather those modules that are exclusively required by unit test code.