This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Improve the type hints of synapse.api.errors.#7820
Merged
Conversation
erikjohnston
suggested changes
Jul 13, 2020
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
Does this now pass mypy synapse/api/errors.py?
Member
Author
|
Member
I really expected that it would have picked up the |
erikjohnston
approved these changes
Jul 14, 2020
Member
Author
I think mypy is "smart" in that case (when the default is |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '4db150951': Improve the type hints of synapse.api.errors. (#7820)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started doing this in #7802 and realized it was bigger than I wanted so I split it out.
It adds more type hints to
synapse.api.errors.