This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Link to the contributing guide if newsfragment check fails#8002
Closed
anoadragon453 wants to merge 1 commit into
Closed
Link to the contributing guide if newsfragment check fails#8002anoadragon453 wants to merge 1 commit into
anoadragon453 wants to merge 1 commit into
Conversation
Member
Author
|
I've realised this would make more sense to sit in the pipeline instead: matrix-org/pipelines#82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are now multiple cases of community contributors being confused about what to do when the newsfragment check fails:
When
python -m towncrier.check --compare-with=origin/developfails, it exits with error code1, otherwise exit code0when the check succeeds. We use this toechoa link to the changelog contributing guide when the check fails, to hopefully allow contributors to be informed and solve the issue themselves.