This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add an admin API for server media statistics#8723
Closed
dklimpel wants to merge 3 commits into
Closed
Conversation
Member
|
This API doesn't strike me as super useful as is; were you planning on extending it with extra information? I'm mostly thinking that if we are going to end up extending this then it'd be good to know what that would roughly look like up front so that we can make sure the APIs make sense up front 🙂 |
Member
|
@dklimpel Were you planning on making further changes to this / rethinking it? |
Contributor
Author
|
Yes, it is in progress. Other tasks have a higher priority at the moment. |
Member
|
@dklimpel I'm going to close the PR for now. We'd obviously be delighted to reopen it if/when you have time to pick it up again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
GET /_synapse/admin/v1/statistics/server/mediato get statisics about local media usage.Related to #6094 and #8700
I am not sure if we should mark this API as draft.
Maybe is it better move to
GET /_synapse/admin/v1/statistics/serverorGET /_synapse/admin/v1/statisticsand also add information like number of registered users.Or should I am add number of registered users to this PR?
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.Signed-off-by: Dirk Klimpel dirk@klimpel.org