This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Begin to phase out use of event_json, rejections and state_events#9413
Closed
richvdh wants to merge 5 commits into
Closed
Begin to phase out use of event_json, rejections and state_events#9413richvdh wants to merge 5 commits into
event_json, rejections and state_events#9413richvdh wants to merge 5 commits into
Conversation
richvdh
force-pushed
the
rav/kill_event_json
branch
2 times, most recently
from
3db500e to
955945e
Compare
richvdh
force-pushed
the
rav/kill_event_json
branch
from
955945e to
469cd5e
Compare
Contributor
|
I think this is a good idea, when i was poking at the database to find out where all events are stored, i was a little confused why there was +1 to the idea of "background updates", though maybe communicate that better in changelogs, keep it around for a while, and then move the logic to a database "delta" script (so for larger version jumps, it happens on startup). Probably not the best experience to those servers who havent migrated from a version that did that background migration, but i think then it'll be pretty smooth. |
Add some new columns to the `events` table, and begin populating them for new events.
richvdh
force-pushed
the
rav/kill_event_json
branch
from
469cd5e to
219f3cb
Compare
Member
Author
|
I think I'm probably not going to take this forward in its current form. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is to collect all the stuff that is commonly selected together into one table, rather than having it scattered around the filesystem.
I benchmarked the new
_fetch_event_rowsquery based on 100 queries I pulled out of my slow query log. On my I/O constrained server, it reduced the average time taken to fetch a batch of events from 9.7 seconds to 5.4 seconds.Unfortunately I don't have good metrics for how much storage increased by, but I don't think it was that bad (like 2%).
Obviously, we will need a background update to populate the new columns. I'm mostly floating this to gather comments at this stage.
Based on #9411.