Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Remove state events from /admin/v1/rooms/<room_id>/context/<event_id>#9615

Closed
Yoric wants to merge 1 commit into
matrix-org:developfrom
Yoric:yoric/faster-admin-context
Closed

Remove state events from /admin/v1/rooms/<room_id>/context/<event_id>#9615
Yoric wants to merge 1 commit into
matrix-org:developfrom
Yoric:yoric/faster-admin-context

Conversation

@Yoric
Copy link
Copy Markdown
Contributor

@Yoric Yoric commented Mar 15, 2021

Real-world tests show that this API is too slow (and timeouts) because serialization
of state events can be extremely slow when there are too many state events, e.g.
in irc rooms.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off
  • Code style is correct (run the linters)

…event_id>

Real-world tests show that this API is too slow (and timeouts) because serialization
of state events can be extremely slow when there are too many state events, e.g.
in irc rooms.

Signed-off-by: David Teller <davidt@element.io>
@Yoric Yoric force-pushed the yoric/faster-admin-context branch from d07f1c1 to 59f3978 Compare March 15, 2021 11:43
@anoadragon453
Copy link
Copy Markdown
Member

Heads up that the performance issues may be addressed by #9619. Plus @erikjohnston expressed concern that a Context API is supposed to include state events.

@clokep
Copy link
Copy Markdown
Member

clokep commented Mar 31, 2021

I think this can be closed since #9619 fixed the root cause? Please re-open if this is incorrect.

@clokep clokep closed this Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants