This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Revert "Leave out optional keys from /sync (#9919)"#9940
Merged
Conversation
This reverts commit e9eb354.
Contributor
|
iOS issue: element-hq/element-ios#4309 |
7 tasks
richvdh
approved these changes
May 6, 2021
Contributor
|
Do I need to do anything to get that back in in a few weeks then or will that be done automatically? :3 |
2 tasks
Contributor
I've filed #9941 to track re-introducing that change. The |
Contributor
|
Thank you! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e9eb354 / #9919
The PR breaks Element iOS push, as its handling expects some of the keys to be there. We revert while they fix it and put out a new release.