Update user directory variable to right type and name#1177
Merged
Conversation
richvdh
reviewed
Dec 9, 2021
richvdh
reviewed
Dec 9, 2021
Comment on lines
269
to
271
| # update_user_directory is kept for backwards compatibility, | ||
| # worker_to_update_user_directory is prioritized before this option. | ||
| update_user_directory => ( not $self->{workers} ), |
Member
There was a problem hiding this comment.
presumably once matrix-org/synapse#11450 lands, this will be removed?
Contributor
Author
There was a problem hiding this comment.
Not directly, i'd like to wait until most/all branches have been updated with the develop branch, else you'll get unrelated sytest errors :/
I'll make a reminder to revisit this in a few months or so, then enumerate all open PRs, and see if they include the commit in their branch or not. If it's not a lot of PRs left, ill just boop them with "hey, please update to develop", and throw a PR in here which removes this option.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Contributor
Author
|
I'm changing this to address matrix-org/synapse#11450 (comment), so i dont throw in a third PR after the fact, to make a single change, stand by. |
ShadowJonathan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a small problem introduced by #1174, i thought that
"null"would become a null yaml value, but it seems not.This tries
undef()instead.After some review over in matrix-org/synapse#11450 im also using this PR to change over the config variable name to
update_user_directory_on