Add basic /admin/purge_history tests#260
Merged
Merged
Conversation
| content => {} | ||
| )->main::expect_http_403; # Must be server admin | ||
| })->then( sub { | ||
| matrix_sync( $user ) |
Contributor
There was a problem hiding this comment.
What's this matrix_sync for?
| # Wait until the remote server has received the last message, so that | ||
| # we know we can later backfill from the remote to get all the events. | ||
| repeat( sub { | ||
| matrix_sync_again( $remote_user ) |
Contributor
There was a problem hiding this comment.
Maybe add a timeout param here so it doesn't tightloop when polling?
| ->then( sub { | ||
| matrix_join_room( $remote_user, $room_id ) | ||
| })->then( sub { | ||
| matrix_put_room_state( $user, $room_id, |
Contributor
There was a problem hiding this comment.
Maybe add a _synced before calling matrix_sync?
Contributor
There was a problem hiding this comment.
Actually this is probably fine if you don't care what sync token you get here.
Member
Author
|
@matrixbot retest this please |
Member
Author
|
@NegativeMjark PTAL |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matrix-org/synapse#911