Add tests for /_matrix/media/r0/config#456
Conversation
|
if you made your branches have the same name, the sytests would run against the right branch of synapse... |
| )->then( sub { | ||
| my ( $body, $response ) = @_; | ||
|
|
||
| assert_json_keys( $body, qw( m.upload.size ) ); |
There was a problem hiding this comment.
given that this is optional, I'm not sure it is correct to assert it here.
You could assert that, if it is present, it is an int of a plausible size?
This really aught to be mentioned somewhere on the matrix-org/synapse README. |
You keep using that word. I do not think it means what you think it means. Anyway, if anywhere, it should be in CONTRIBUTING, but it's a hack that only works for people in the matrix-org github org, so I'm unsure it should be there. |
|
Closing and reopening so sytest will apparently test against the correct thing. |
2 participants
Not sure how I will go about testing the value, or if it's necessary.
Tests matrix-org/synapse#3184