initial room summary tests#470
Merged
Merged
Conversation
ara4n
force-pushed
the
matthew/room_summary
branch
2 times, most recently
from
2b069b5 to
d0ad3cb
Compare
richvdh
approved these changes
Aug 13, 2018
| matrix_create_room_synced( $alice ); | ||
| })->then( sub { | ||
| ( $room_id ) = @_; | ||
| matrix_join_room( $bob, $room_id ); |
Member
There was a problem hiding this comment.
you'll need join_room_synced here to avoid (or reduce the chance of) races
Member
|
(though should we be alarmed that the tests are failing?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests for matrix-org/synapse#3574