tests for cross-signing#597
Merged
Merged
Conversation
richvdh
approved these changes
Jul 23, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
I've only skimmed this tbh but it looks eminently sane. obvs it needs to wait for the synapse PRs to land and it would be good to fix the nits below.
Member
Author
|
Probably needs re-review since I've made some more invasive changes since the last review. |
richvdh
requested changes
Aug 12, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corresponds to matrix-org/synapse#4970