Add regression tests for synapse#5269#615
Merged
Merged
Conversation
richvdh
approved these changes
May 30, 2019
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
generally lgtm. some nitpicking about the comments.
| # PL1 = creator of room blocks SF event sending | ||
| # M1 = remote user sends a permitted message | ||
| # SF1 = remote user sends a soft-failed message | ||
| # SF2 = remote user sends a soft-failed message |
Member
There was a problem hiding this comment.
I think SF2 is unnecessary in this test? you could get rid of it, if you could be bothered.
Member
Author
There was a problem hiding this comment.
Yes, ish, though it validates the logic a bit better since the test then checks the correct handling of chains of soft failed events.
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c.f. matrix-org/synapse#5274