Skip to content

UISI test#659

Merged
JorikSchellekens merged 6 commits into
developfrom
joriks/uisi_test
Jul 29, 2019
Merged

UISI test#659
JorikSchellekens merged 6 commits into
developfrom
joriks/uisi_test

Conversation

@JorikSchellekens
Copy link
Copy Markdown
Contributor

Comment thread tests/41end-to-end-keys/06-device-lists.pl Outdated
@erikjohnston
Copy link
Copy Markdown
Member

The tests are broadly good, but the problem with killing one of the servers is that they are used for the entire test run, rather than being set up for each test. I think a good alternative here is to use the sytest server implementation and then we can simulate the server "going down" by having it return e.g. a 503.

@JorikSchellekens
Copy link
Copy Markdown
Contributor Author

The server is restarted at the end. Does the sytest server implementation emulate users actions such as joining rooms and uploading keys? Otherwise this test requires a lot of mocking.

@erikjohnston
Copy link
Copy Markdown
Member

Does the sytest server implementation emulate users actions such as joining rooms and uploading keys? Otherwise this test requires a lot of mocking.

Yup, look in test/50federation/ which all use the perl sytest federation thing.

@JorikSchellekens
Copy link
Copy Markdown
Contributor Author

I've changed it over to the sytest federation server

Copy link
Copy Markdown
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a bit of tidying up

Comment thread tests/05homeserver.pl Outdated
Comment thread tests/50federation/40devicelists.pl Outdated
Comment thread tests/50federation/40devicelists.pl Outdated
Comment thread tests/50federation/40devicelists.pl Outdated
Comment thread tests/50federation/40devicelists.pl Outdated
@erikjohnston erikjohnston self-requested a review July 29, 2019 13:51
Copy link
Copy Markdown
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment thread tests/05homeserver.pl Outdated
Comment thread tests/50federation/40devicelists.pl Outdated
@JorikSchellekens JorikSchellekens merged commit 14f8dd7 into develop Jul 29, 2019
@JorikSchellekens JorikSchellekens deleted the joriks/uisi_test branch July 29, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants