Skip to content

Extra tests for make_join/make_leave#660

Merged
richvdh merged 2 commits into
developfrom
erikj/log_leave_origin_mismatch
Jul 26, 2019
Merged

Extra tests for make_join/make_leave#660
richvdh merged 2 commits into
developfrom
erikj/log_leave_origin_mismatch

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

@erikjohnston erikjohnston requested a review from a team July 23, 2019 15:29
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


my $user_id = $user->user_id;

matrix_create_room(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advocate the use of local_user_and_room_fixtures for this, ftr

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Jul 26, 2019

going to merge this, as the sytests are broken without it.

@richvdh richvdh merged commit 56de891 into develop Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants