Add simple /purge_room admin API test#736
Closed
erikjohnston wants to merge 1 commit into
Closed
Conversation
richvdh
reviewed
Oct 31, 2019
Member
richvdh
left a comment
There was a problem hiding this comment.
hrm. I think we've previously decided that testing the synapse-specific endpoints in sytest was a mistake (since it makes it harder to apply sytest to other server impls)
honestly I'd be happy to rely on the UT in matrix-org/synapse#6307 and just bin this
Member
Author
|
That's probably fair, though we probably want to think about what to do about the other tests in the file |
Member
Author
|
I guess one thing that this does test is if they work in worker mode? |
Member
|
still kinda think we want to test that in |
Member
kill them kill them all MWAHAHAHAHAHA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/synapse#6307