Skip to content

Add simple /purge_room admin API test#736

Closed
erikjohnston wants to merge 1 commit into
developfrom
erikj/fix_purge_room
Closed

Add simple /purge_room admin API test#736
erikjohnston wants to merge 1 commit into
developfrom
erikj/fix_purge_room

Conversation

@erikjohnston
Copy link
Copy Markdown
Member

@erikjohnston erikjohnston commented Oct 31, 2019

@erikjohnston erikjohnston requested a review from a team October 31, 2019 11:34
Copy link
Copy Markdown
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm. I think we've previously decided that testing the synapse-specific endpoints in sytest was a mistake (since it makes it harder to apply sytest to other server impls)

honestly I'd be happy to rely on the UT in matrix-org/synapse#6307 and just bin this

@erikjohnston
Copy link
Copy Markdown
Member Author

That's probably fair, though we probably want to think about what to do about the other tests in the file

@erikjohnston
Copy link
Copy Markdown
Member Author

I guess one thing that this does test is if they work in worker mode?

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Oct 31, 2019

still kinda think we want to test that in synapse/tests rather than here... even if that means doing a bunch of annoying boilerplatey work to get a pair of workers set up in a trial env.

@richvdh
Copy link
Copy Markdown
Member

richvdh commented Oct 31, 2019

what to do about the other tests in the file

kill them

kill them all

MWAHAHAHAHAHA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants