Fix a flaky cross-signing test#749
Merged
Merged
Conversation
The basic problem in this test is that there are three things that can cause a "devices/changed" sync update: * inviting the user * the user joining * the user doing his cross-signing ... and it's hard to be sure that we're getting the right update. If we make sure that we wait for each update, it fixes the race condition.
richvdh
requested review from
a team and
uhoreg
and removed request for
a team
Member
Author
|
@uhoreg perhaps you'd like to review this one :) |
uhoreg
approved these changes
Nov 26, 2019
Member
uhoreg
left a comment
uhoreg
left a comment
There was a problem hiding this comment.
Yup, this looks like the sort of thing that I should be looking at. ;)
looks reasonable
anoadragon453
added a commit
that referenced
this pull request
Mar 18, 2020
…ase-v1.6.x * origin/release-v1.6.1: (32 commits) Move scripts which aren't in docker out of `docker` (#752) README.md: don't forget to update dendrite:latest fix another results.tap Fix path to results.tap for dendrite build remove redundant (and failing) tap-to-junit Don't modify source volumes when running in docker (#748) Fix a flaky cross-signing test (#749) Add tests for 3PID registration (#695) Update the SyTest Docker files (#744) rejected state test (#742) Add test for rooms transferring on groups after room upgrade (#737) test pushes of rejected events (#738) Tests for room tags and push rules after upgrading a remote room (#721) Test that a room is depublished from the public rooms list upon room upgrade (#729) Review comments Tests for signatures and auth on /send_join etc (#734) Wrap in retry loop as room dir is updated async Tests room dir search Wrap numbers in JSON bodies (#733) Add frontend proxy worker ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic problem in this test is that there are three things that can cause a
"devices/changed" sync update:
... and it's hard to be sure that we're getting the right update. If we make
sure that we wait for each update, it fixes the race condition.