Switch to YAML::XS for YAML serialisation#888
Merged
Merged
Conversation
it's better at understanding the difference between `1`, `true`, and `"true"`. This leads to a few fixes around the codebase where it turned out we were getting away with some sloppiness thanks to `YAML`'s idiosyncracies.
richvdh
commented
Jun 12, 2020
Comment on lines
+2
to
+3
| server-0/ | ||
| server-1/ |
Member
Author
There was a problem hiding this comment.
this is kinda unrelated but was something I came across when trying to rebuild the docker images to include YAML::XS.
richvdh
commented
Jun 12, 2020
| use List::Util qw( any ); | ||
| use POSIX qw( strftime WIFEXITED WEXITSTATUS ); | ||
|
|
||
| use YAML (); |
richvdh
commented
Jun 12, 2020
| type => "http", | ||
| port => $unsecure_port, | ||
| bind_address => $bind_host, | ||
| tls => 0, |
Member
Author
There was a problem hiding this comment.
tls and compress are both disabled by default.
clokep
approved these changes
Jun 12, 2020
Member
clokep
left a comment
clokep
left a comment
There was a problem hiding this comment.
Seems reasonable.
Straight from their docs they say to use YAML::XS too:
If you want robust and fast YAML processing using the normal Dump/Load API, please consider switching to YAML::XS. It is by far the best Perl module for YAML at this time.
valkum
added a commit
to valkum/sytest
that referenced
this pull request
Jul 14, 2020
anoadragon453
added a commit
that referenced
this pull request
Aug 4, 2020
* origin/release-v1.15.2: Unbreak dendrite build; use json true Switch to YAML::XS for YAML serialisation (#888) Add DENDRITE_TRACE_INTERNAL
valkum
added a commit
to valkum/sytest
that referenced
this pull request
Aug 26, 2020
valkum
added a commit
to valkum/sytest
that referenced
this pull request
Sep 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's better at understanding the difference between
1,true, and"true". This leads to a few fixes around the codebase where it turned out wewere getting away with some sloppiness thanks to
YAML's idiosyncracies.