Skip to content

Fix bad tests #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikjohnston merged 1 commit into from
Aug 24, 2020
Merged

Fix bad tests #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tests/10apidoc/03events-initial.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,7 @@ sub matrix_sync
)->on_done( sub {
my ( $body ) = @_;

assert_json_keys( $body, qw( account_data rooms presence next_batch ) );
assert_json_keys( $body->{presence}, qw( events ));
assert_json_keys( $body->{rooms}, qw( join invite leave ) );
assert_json_keys( $body, qw( next_batch ) );

if ( $update_next_batch ) {
$user->sync_next_batch = $body->{next_batch};
Expand Down
2 changes: 1 addition & 1 deletion tests/10apidoc/11profile-avatar_url.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
my $user_fixture = local_user_fixture();

my $avatar_url = "http://somewhere/my-pic.jpg";
my $avatar_url = "mxc://example.com/SEsfnsuifSDFSSEF";
Copy link
Copy Markdown
Member

@anoadragon453 anoadragon453 Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up this definitely isn't the only occurrence of an http:// URL being used as an avatar in the codebase.


test "PUT /profile/:user_id/avatar_url sets my avatar",
requires => [ $user_fixture ],
Expand Down