Skip to content

Better logging for a flaky test #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richvdh merged 1 commit into from
Oct 6, 2020
Merged

Better logging for a flaky test #966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/30rooms/70publicroomslist.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,11 @@
# First we fill up the room list a bit (note there will probably already
# be entries in it).
( try_repeat {
matrix_create_room( $user, visibility => "public" )
my $n = $_;
matrix_create_room( $user, visibility => "public" )->on_done( sub {
my ( $body ) = @_;
log_if_fail "Created room $n", $body;
});
} foreach => [ 1 .. 10 ] )->then( sub {
# Now we do an un-limited query to work out the number of rooms we
# expect.
Expand All @@ -177,6 +181,8 @@
})->then( sub {
my ( $body ) = @_;

log_if_fail "initial /publicRooms response", $body;

$num_rooms = scalar( @{ $body->{chunk} } );

# Now we iterate through the room list, recording how often we see a
Expand Down