Ensure that SSO users are registered before trying to UI auth them.#990
Merged
Conversation
Member
Author
|
This is necessary for matrix-org/synapse#8856 |
erikjohnston
approved these changes
Dec 16, 2020
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
I think this looks broadly sane?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some tests for UI auth + SSO, but they're performed with users who aren't actually logged in via SSO, so the resulting authentication flows don't really make sense.
This modifies the UI auth + SSO tests to log the users in via SSO, not via normal login. (This allows a homeserver to know that they're an SSO user, not user that logs in via a password.)
The diff here is pretty awful, but I pretty much abstracted the "Can login with new user via CAS" to a sub (
matrix_login_with_cas) that then gets used in multiple places. It also pulls thecas_login_fixtureinto the UI auth tests as well and adds a new subgenerate_cas_responseinstead of hard-coding the same XML in many places.