Add generic types and ability to mutate files on update and delete operations#3
Merged
matschik merged 3 commits intomatschik:mainfrom Jan 27, 2026
Merged
Conversation
moritzleidinger
commented
Jan 13, 2026
Contributor
Author
|
Hi, just wanted to ask, if you'd consider merging my changes / additions. I'm happy to adapt, if you'd like. Otherwise I'll close the PR and fork. Thanks! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, great library!
I've used it in a small project a bit, but ended up needing the ability to actually mutate the source files when updating or deleting rows. In this PR I've added a parameter (mutateDb) to the
add,updateanddeletemethods with default values that keep the current behaviour (mutating for add, non-mutating for update and delete). To make this an atomic operation, I've used yourtemporaryFileTaskto update/delete the values in a temp file and subsequently replace the original file in a single rename operation.I've also added generic types that can be passed like this:
jsonlDir("path").file<DataType>("name"). This provides type safety for returned rows – and falls back to the existingJsonObjecttype if no type is provided.I've also added tests to cover update and delete when passing
mutateDb=true.