Test if thumbnail is GdImage#26
Open
jhoekx wants to merge 1 commit into
Open
Conversation
In PHP 8, GD returns GdImage objects and not resources. To check if a thumbnail could be created, `is_resource()` was used. Since the thumbnail is no longer a resource, this check now fails and the default thumbnail was used for all maps. See https://php.watch/versions/8.0/gdimage#gdimage-is-resource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PHP 8, GD returns GdImage objects and not resources. To check if a thumbnail could be created,
is_resource()was used. Since the thumbnail is no longer a resource, this check now fails and the default thumbnail was used for all uploaded maps.See https://php.watch/versions/8.0/gdimage#gdimage-is-resource
Note that I only have access to a system with PHP 8. According to the linked document, this fix works in PHP 7 as well, but was not tested by me. Not sure about earlier versions.