Fix - Deprecated PHP 8.1

[LadySolveig]

Fix for
Deprecated
: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in api-library/lib/Auth/OAuth.php on

• line 388
• line 395
• line 637

[cla-bot]

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @LadySolveig.

[LadySolveig]

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @LadySolveig.
Signed ✅

[RCheesley]

@cla-bot check

Thanks for signing the CLA @LadySolveig and welcome to the Mautic community!

We have quite a bit of work to do on 8.1 support in Mautic, we're hoping to get it in for the 5.0 release. If you've got any capacity to help with that please do let us know!

[cla-bot]

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

[escopecz]

The changes make sense. Thanks for taking care of this!

I think it could be simplified.

[LadySolveig]

The changes make sense. Thanks for taking care of this!

I think it could be simplified.

You're absolutely right. I saw the line 525 in code where it was just fixed with

return !empty($this->_request_token_url) && strlen($this->_request_token_url) > 0;

Perhaps this could be also only

return !empty($this->_request_token_url);

[escopecz]

Looks good to me! Thank you! We have the tests broken since last week as we are upgrading Mautic to Symofny 5. We'll fix that on the Mautic's side and re-run the tests to get the CI check green. Once it's green we can merge this PR.

[RCheesley]

@all-contributors please add @LadySolveig for code

[allcontributors]

@RCheesley

I've put up a pull request to add @LadySolveig! 🎉

[RCheesley]

@all-contributors please add @escopecz for review

[allcontributors]

@RCheesley

I've put up a pull request to add @escopecz! 🎉

[PierreAmmeloot]

Hello @RCheesley, I have check on my side.
It's OK.

Can you close and merge this fix?

Pierre

[RCheesley]

@PierreAmmeloot please can you leave your review as detailed here so that it counts as a contribution and tells GitHub we have had a positive review?

Also as @escopecz mentioned we can't merge this until the tests are passing, which is pending some fixes being merged in mautic/mautic (I think they might have just got fixed - just re-running the tests).

If you have any time we would greatly appreciate some help testing and reviewing the PRs for the Symfony 5 project. Check out #t-product on Slack for more guidance from the team in that regard!

[escopecz]

Yep, the CI is green. Merging.