Bumping PHP from 8.1 to 8.3 in the CI#337
Merged
escopecz merged 3 commits intomautic:mainfrom Mar 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI configuration to use PHP 8.3, ensuring compatibility with Symfony 7 and future-proofing the environment. The changes include updating the PHP version parameter in the setup actions, modifying the package installation commands, and adjusting the PHP configuration file paths accordingly.
Files not reviewed (19)
- composer.json: Language not supported
- lib/Api/Api.php: Language not supported
- lib/Api/Assets.php: Language not supported
- lib/Api/CampaignEvents.php: Language not supported
- lib/Api/Campaigns.php: Language not supported
- lib/Api/Categories.php: Language not supported
- lib/Api/Companies.php: Language not supported
- lib/Api/CompanyFields.php: Language not supported
- lib/Api/ContactFields.php: Language not supported
- lib/Api/Contacts.php: Language not supported
- lib/Api/Data.php: Language not supported
- lib/Api/Devices.php: Language not supported
- lib/Api/DynamicContents.php: Language not supported
- lib/Api/Emails.php: Language not supported
- lib/Api/Files.php: Language not supported
- lib/Api/Focus.php: Language not supported
- lib/Api/Forms.php: Language not supported
- lib/Api/Messages.php: Language not supported
- lib/Api/Notes.php: Language not supported
matbcvo
approved these changes
Mar 27, 2025
Contributor
matbcvo
left a comment
matbcvo
left a comment
There was a problem hiding this comment.
The code changes look good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we've updated the main branch in the https://github.com/mautic/mautic repo from 6.x to 7.x we also have to upgrade the PHP version that is running the CI tests. Symfony 7 supports PHP 8.2+. I'm changing it to PHP 8.3 already so we don't have to change it again in the near future.
The PHP bump required the PHP CS FIXER library update as it didn't support PHP 8.2+. Then I run the
vendor/bin/php-cs-fixer fixcommand to update the code style for this new version which generated most of the changes in this PR.