Comms: Fix Mavlink Loss Percent #12911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Nice! Does this work properly now with multiple components? When using mavlink-router the sequence numbers would be out of order since some packets would come from compid X and other packets from compid Y. |
Collaborator
Author
|
Originally there was a weird mix of logic where it seemed like they were tracking sysid/compid in one place but then use channels for the same variables in another place. Not 100% sure this completely resolves that but it is a step in that direction |
Collaborator
Author
|
There's also the issue of how UDP packets can come in out of order, so probably I'll come back and take a deeper look at this again soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.