CMake: Fix QML module conversion for Qt 6.6.3 #12957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, static QML module libraries were linked using non-existent plugin targets. This commit replaces that workaround with the NO_PLUGIN option in qt_add_qml_module, which is the supported way to disable plugin generation for static QML modules.
rubenp02
force-pushed
the
bugfix/fix-qml-module-conversion-for-qt-6.6.3
branch
2 times, most recently
from
7d0293c to
d4d8bab
Compare
Fixed issues with the runtime discovery of modules defined with qt_add_qml_module in 6.6.3, which were causing the app to crash on startup. Key changes: - Explicitly linked all QML modules defined with qt_add_qml_module. - Added the NO_PLUGIN option to all qt_add_qml_module calls, as unlike in Qt 6.8.X, it is always needed in 6.6.3 for this style of module. Note: This commit should be reverted once Qt 6.6.3 support is dropped.
rubenp02
force-pushed
the
bugfix/fix-qml-module-conversion-for-qt-6.6.3
branch
from
d4d8bab to
70dd3dd
Compare
Collaborator
|
Ok, so then #12974 isn't needed right? |
Collaborator
|
@rubenp02 Can you create an Issue which details what should be changed back when we bail on 6.6.3 support and assign to me? |
Collaborator
|
Changed look good. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix QML module conversion for Qt 6.6.3
Description
Fixed issues with the runtime discovery of modules defined with qt_add_qml_module in 6.6.3, which were causing the app to crash on startup.
Key changes:
Note: The changes above should be reverted once Qt 6.6.3 support is dropped.
In addition to this, the plugin workaround used in some of these modules has been replaced with the NO_PLUGIN option in qt_add_qml_module, which is the supported way to disable plugin generation for static QML modules.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.