CustomPlugin: Fix QApplicationStatic for Qt 6.6.3 #12958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the example implementation of the CustomPlugin to include the QtCore/QApplicationStatic header only for Qt versions over 6.8.0, where it was introduced.
Contributor
Author
|
This was breaking custom builds on Qt 6.6.3. |
Collaborator
|
Oh I think it exists but you have to include via the actual header qapplicationstatic.h |
Contributor
Author
|
I did know that but it appeared to be included indirectly so I just left it that way. Happy to explicitly include it if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomPlugin: Fix QApplicationStatic for Qt 6.6.3
Description
Updated the example implementation of the CustomPlugin to include the QtCore/QApplicationStatic header only for Qt versions over 6.8.0, where it was introduced.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.