ArduPilot: Remove hardcoded flight mode names #13354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes hardcoded flight mode names from ArduPilot firmware plugins by moving them from inline return statements to proper method implementations that use dynamic mode mappings.
- Replaces hardcoded string literals in header files with method declarations
- Implements new methods in .cc files that use
_modeEnumToStringmapping for dynamic flight mode names - Adds debug logging for flight mode changes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/FirmwarePlugin/FirmwarePlugin.cc | Adds debug logging for flight mode transitions |
| src/FirmwarePlugin/APM/ArduRoverFirmwarePlugin.h | Moves hardcoded "Hold" and "Follow" modes to method declarations |
| src/FirmwarePlugin/APM/ArduRoverFirmwarePlugin.cc | Implements pauseFlightMode() and followFlightMode() using dynamic mappings |
| src/FirmwarePlugin/APM/ArduPlaneFirmwarePlugin.h | Moves hardcoded "Loiter" mode to method declaration |
| src/FirmwarePlugin/APM/ArduPlaneFirmwarePlugin.cc | Implements pauseFlightMode() using dynamic mapping |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
This fixes the issue! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13224
@rubenp02 Can you verify this works for you?