Frontend Overhaul + Admin mode#3
Open
NiklasKy wants to merge 3 commits into
Open
Conversation
maxider
reviewed
Nov 6, 2025
Owner
maxider
left a comment
maxider
left a comment
There was a problem hiding this comment.
I'll review the frontend later
| using System.Security.Cryptography; | ||
| using System.Text; | ||
|
|
||
| namespace FunWithEF.Controllers; |
Owner
There was a problem hiding this comment.
Namespace should be 'LogNineBackend.Controllers'. This is also wrong in the 'TeamsController'
| } | ||
|
|
||
| private bool VerifyAdminPassword(string? password) { | ||
| if (string.IsNullOrWhiteSpace(password)) |
| public int Id { get; set; } | ||
|
|
||
| [Required] | ||
| [StringLength(200, MinimumLength = 1)] |
Owner
There was a problem hiding this comment.
The default state contradicts the default. Instead set no default.
| public Team? Target { get; set; } | ||
|
|
||
| [Required] | ||
| [StringLength(200, MinimumLength = 1)] |
| public String Name { get; set; } | ||
|
|
||
| [Required] | ||
| [StringLength(100, MinimumLength = 1)] |
|
|
||
| [Required] | ||
| [StringLength(100, MinimumLength = 1)] | ||
| public string Name { get; set; } = string.Empty; |
|
|
||
| // Configure CORS with proper settings | ||
| var allowedOrigins = builder.Configuration.GetSection("AllowedOrigins").Get<string[]>() | ||
| ?? new[] { "http://localhost:8081", "http://localhost:5173" }; |
Owner
There was a problem hiding this comment.
Pull this from the app settings instead of hardcoding it.
| var maxRequestSizeKB = builder.Configuration.GetValue<int>("MaxRequestSizeKB", 1024); // Default 1MB | ||
| app.Use((context, next) => { | ||
| if (context.Request.ContentLength > 10 * 1024) | ||
| if (context.Request.ContentLength > maxRequestSizeKB * 1024) |
| if (context.Request.ContentLength > maxRequestSizeKB * 1024) | ||
| { | ||
| logger?.LogWarning("Request rejected: Content length {ContentLength} exceeds limit {Limit}", | ||
| context.Request.ContentLength, maxRequestSizeKB * 1024); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pull request integrates my frontend overhaul plus a admin mode for all boards.
Further changes will be made to the documentation regarding languange change