Fix dropdown dissappearing on first selection on quick tags mode #137
Open
RisPNG wants to merge 2 commits intomaxmarcon:mainfrom
Open
Fix dropdown dissappearing on first selection on quick tags mode #137RisPNG wants to merge 2 commits intomaxmarcon:mainfrom
RisPNG wants to merge 2 commits intomaxmarcon:mainfrom
Conversation
… causing the field to get unfocused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue refer to #136.
In quick_tags mode, instead of forcing the setting hide_dropdown to true on blur, it makes sure to persist the state of hide_dropdown.
However, solving it this way alone introduces a new issue where when blur is triggered in quick_mode by user intention (clicking outside the field or dropdown), the dropdown won't close, so I added a new self_blur handle event that sets the hide_dropdown to true as the original code and an event listener that checks whether the field has been unfocused to then calls self_blur to restore this intended behaviour.
Here is the video showing before:
Screencast.From.2026-02-20.10-45-21.mp4
and after:
Screencast.From.2026-02-20.11-02-33.mp4