Conversation
Member
oschwald
commented
May 4, 2026
- Reject unsupported sockaddr families
- Reject empty metadata sections
- Reject search tree records in separator
- Return an error for invalid search nodes
There was a problem hiding this comment.
Code Review
This pull request addresses several security and stability issues, including an out-of-bounds read in MMDB_lookup_sockaddr, improved search-tree validation to reject records pointing into the separator, and fixes for metadata parsing. It also introduces new tests for these scenarios. The review feedback points out that the newly added test files are not cross-platform and will likely fail to build on Windows due to reliance on POSIX-specific headers and functions.
3dc7fbc to
bc7fccf
Compare
Merged
2 tasks
7e484ff to
c3ff558
Compare
c3ff558 to
5f40c27
Compare
horgh
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.