Allow to set IP address to analyze#60
Allow to set IP address to analyze#60marcstern wants to merge 105 commits intomaxmind:masterfrom marcstern:master
Conversation
|
My test install works, but the general Apache setup (from the trunk) is incorrect. |
|
Hi; I'll try taking a look at this tomorrow. In the mean-time, I'm wondering what the test failures are about, but haven't had a chance to look yet. |
|
I fixed 5 problems. |
|
Hi; I'm not sure where the test config came from. I thought I'd have time to take a look at this today but I am a bit backed up with other work. I will look at it tomorrow with a coworker and will get back to you with, at the least, preliminary feedback by the end of the day then. |
|
@marcstern I'm really sorry that I haven't found the time to dig into this yet. I promise you, I'll do my best to leave some concrete feedback by the end of the week. |
|
Hi @marcstern , both a coworker and I spent several hours trying to get this PR passing tests and failed. We think it's not a bad idea in principle but it's going to be hard to maintain this patch without tests and given that it's just so hard to get the environment variable set at just the right time (and to document with an example) we prefer not to merge this PR as is. Thanks for your contribution. If you or someone can come up with a more easily testable and documentable solution, we may consider it, so we're leaving tihs PR open. |
|
Closing this PR, updated code is in #66 |
Added mod_security2 build, install and config.
Added test to trigger it from the URL (query string).