Allow specification of the IP address to check via environment variable#64
Closed
Allow specification of the IP address to check via environment variable#64
Conversation
- check for MMDB Lookup results and verify that they are different depending on whether the IP is set via the env var or not - use an IP found in the database to confirm the lookup worked
…axminddb into marcstern/envvar
oschwald
reviewed
Sep 5, 2018
| [mod_remoteip](http://httpd.apache.org/docs/current/mod/mod_remoteip.html) may | ||
| be used to set the client IP address. | ||
|
|
||
| Manually setting the client IP address is also possible - see |
Member
There was a problem hiding this comment.
Get rid of the hyphen and add a period. "See" is the start of a new sentence.
| In case you want supply your own value for the IP address to lookup, it may be | ||
| done by setting the environment variable `MMDB_ADDR`. | ||
| This can be done, for instance, with | ||
| [ModSecurity](https://github.com/SpiderLabs/ModSecurity/) in (real) phase 1. |
Member
There was a problem hiding this comment.
Should we note that this doesn't actually work with ModSecurity out of the box (at least on most distros) and that you need to specially compile it? My primary objection to this change is that it is almost impossible to use this correctly.
| ScriptAlias /cgi-bin/ "@ServerRoot@/cgi-bin/" | ||
|
|
||
| LogLevel debug | ||
| #LogLevel debug |
Member
There was a problem hiding this comment.
We shouldn't leave uncommented code. Maybe we could switch it back to debug unless there is a good reason not to.
Contributor
Author
|
Closing this PR, updated code is in #66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.