Open
Conversation
eliranamar
reviewed
Sep 26, 2018
src/GoogleAuthorize.js
Outdated
| if (responseType === 'code') { | ||
| if (params.response_type === 'code') { | ||
| params.access_type = 'offline'; | ||
| params.response_type = 'code'; |
There was a problem hiding this comment.
no need for this duplicate re-assign. please remove line 76
Contributor
There was a problem hiding this comment.
@MaxwellGBrown any chance to do this, and to also add a test?
Author
There was a problem hiding this comment.
@eliranamar Thank you; Dropped line 76.
@advance512 Will look into it. Doesn't look as if there's any tests for the click event, and gapi isn't mocked out or anything, so I'll see if the effort required matches my desired involvement 😬 .
|
What is the status of this? Any chance we can get this merged + published? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's handling for
responseType="code"but it's hard-coded.Google allows
responseType="id_token token"which is in the README table, but it is not actually passed toparams.