Open
Conversation
fabianmarinog
requested changes
Jul 11, 2022
Comment on lines
+14
to
+15
| <label for="name">Apellido</label> | ||
| <input type="text" id="apellido" name="user_name"> <br> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <label for="name">Apellido</label> | |
| <input type="text" id="apellido" name="user_name"> <br> | |
| <label for="apellido">Apellido</label> | |
| <input type="text" id="apellido" name="last_name"> <br> |
Comment on lines
+18
to
+19
| <label for="date"> fecha</label> | ||
| <input type="date" id="start" name="trip-start" |
Collaborator
There was a problem hiding this comment.
Suggested change
| <label for="date"> fecha</label> | |
| <input type="date" id="start" name="trip-start" | |
| <label for="start">fecha de nacimiento</label> | |
| <input type="date" id="start" name="trip-start" |
Comment on lines
+22
to
+24
| <input type="radio" name="Hombre" value="Hombre"> Hombre | ||
|
|
||
| <input type="radio" name="Mujer" value="Mujer"> Mujer <br> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <input type="radio" name="Hombre" value="Hombre"> Hombre | |
| <input type="radio" name="Mujer" value="Mujer"> Mujer <br> | |
| <select name="gender" id="gender"> | |
| <option value="m">Masculino</option> | |
| <option value="f">Femenino</option> | |
| <option value="o">Otro</option> | |
| </select> |
En la actividad se especifica usar un <select> para el caso del género.
Comment on lines
+25
to
+26
| <label for="">Estrato 2 </label> | ||
| <input type="radio" name="socioeconómico"> |
Collaborator
There was a problem hiding this comment.
Para los estratos es necesario usar <input type="radio" /> y todos deben tener el mismo name para que se pueda escoger solamente uno.
Comment on lines
+29
to
+32
| <label>Ciclismo<input type="checkbox" id="cbox1" value="checkbox"></label><br> | ||
| <label>Patinaje<input type="checkbox" id="cbox2" value="checkbox"></label><br> | ||
| <label>Gym<input type="checkbox" id="cbox3" value="checkbox"></label><br> | ||
| <label>Baloncesto<input type="checkbox" id="cbox4" value="checkbox"></label><br> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <label>Ciclismo<input type="checkbox" id="cbox1" value="checkbox"></label><br> | |
| <label>Patinaje<input type="checkbox" id="cbox2" value="checkbox"></label><br> | |
| <label>Gym<input type="checkbox" id="cbox3" value="checkbox"></label><br> | |
| <label>Baloncesto<input type="checkbox" id="cbox4" value="checkbox"></label><br> | |
| <label for="ciclismo">Ciclismo<input type="checkbox" id="ciclismo" value="checkbox"></label><br> | |
| <label for="patinaje">Patinaje<input type="checkbox" id="patinaje" value="checkbox"></label><br> | |
| <label for="gym">Gym<input type="checkbox" id="gym" value="checkbox"></label><br> | |
| <label for="baloncesto">Baloncesto<input type="checkbox" id="baloncesto" value="checkbox"></label><br> |
El valor de for del label debe coincidir con el id del campo y además es necesario usar nombres explicitos para evitar ambiguedades.
| <label>Patinaje<input type="checkbox" id="cbox2" value="checkbox"></label><br> | ||
| <label>Gym<input type="checkbox" id="cbox3" value="checkbox"></label><br> | ||
| <label>Baloncesto<input type="checkbox" id="cbox4" value="checkbox"></label><br> | ||
| <form name="subir-imagen" type="POST" enctype="multipart/formdata" > <input type="file" name="imagen" /> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <form name="subir-imagen" type="POST" enctype="multipart/formdata" > <input type="file" name="imagen" /> | |
| <input type="file" name="imagen" /> |
Falta el <label> para el campo imagen.
| <label>Gym<input type="checkbox" id="cbox3" value="checkbox"></label><br> | ||
| <label>Baloncesto<input type="checkbox" id="cbox4" value="checkbox"></label><br> | ||
| <form name="subir-imagen" type="POST" enctype="multipart/formdata" > <input type="file" name="imagen" /> | ||
| <button>Enviar</button> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <button>Enviar</button> | |
| <button type="submit">Enviar</button> |
Es igual el comportamiento por defecto, pero es mejor ser explicitos de la intención del botón.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.