Skip to content

Fixing interstitial directory prefix#6

Open
hitarth64 wants to merge 1 commit intombkumar:masterfrom
hitarth64:patch-1
Open

Fixing interstitial directory prefix#6
hitarth64 wants to merge 1 commit intombkumar:masterfrom
hitarth64:patch-1

Conversation

@hitarth64
Copy link
Copy Markdown

Found this issue where the directories generated for interstitials begin with 'Int_' but pycdt looks for matches that begin with 'inter_'. Updated the 3 instances where this happens and that fixes everything.

Found this issue where the directories generated for interstitials begin with 'Int_' but pycdt looks for matches that begin with 'inter_'. Updated the 3 instances where it happens.
@mbkumar
Copy link
Copy Markdown
Owner

mbkumar commented Dec 13, 2019

Hello Hitarth,

If you look at https://github.com/mbkumar/pycdt/blob/master/pycdt/core/defectsmaker.py:744, we are using 'inter' for interstitials. Not sure how you got 'Int' in the folder names. Did you generate the input files by yourself?

@hitarth64
Copy link
Copy Markdown
Author

Hi Bharat,

Thank you for your reply. I am using a combination of pycdt(2.0.2) and pymatgen(2019.5.28) on python 3.6.

To cross-check, I tried generating the input structures again (using *pycdt generate_input --structure_file POSCAR --include_interstitial Pb) and found that all the directories for interstitials are still prefixed with 'Int_'. Maybe it's just this particular combination of library versions that makes this problem pop up? Thanks!

@mbkumar
Copy link
Copy Markdown
Owner

mbkumar commented Dec 14, 2019 via email

@hitarth64
Copy link
Copy Markdown
Author

Hi Bharat, Here is the link to corresponding POSCAR - https://github.com/hitarth64/pycdt/blob/master/examples/POSCAR

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants