Add option to change volume of stimuli.#1
Open
cranndarach wants to merge 2 commits intomcdermottLab:masterfrom
Open
Add option to change volume of stimuli.#1cranndarach wants to merge 2 commits intomcdermottLab:masterfrom
cranndarach wants to merge 2 commits intomcdermottLab:masterfrom
Conversation
Add volume option to headphoneCheckConfig. Set volume before playing sound. Add volume option setting to calibration sound. Delete comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thanks for sharing this tool! It is proving really helpful for an online auditory experiment I am getting ready to run.
While adding it to the study, I noticed that the sounds were louder than my experimental stimuli. So, I added
headphoneCheck[Default]Config.audioVolumeso that I could adjust the volume programmatically and still use the default stimuli. I figured this might be useful to others, too, hence the pull request. 😃Before a stimulus is played, the
HTMLMediaElement.volumeproperty is set to the specified value. The default value is set to 1.0, meaning it will play at 100% volume. (I tried to set thevolumeproperty when each stimulus was created, but I found that it didn't actually change the volume at all, for some reason.)I also updated the README with a description of the property.
Thank you, and please let me know if there is anything I should change!