Trotterised time evolution test fixes#2
Merged
mcjamieson merged 3 commits intomcjamieson:feature/add-validation-testsfrom Jan 21, 2026
Merged
Trotterised time evolution test fixes#2mcjamieson merged 3 commits intomcjamieson:feature/add-validation-testsfrom
mcjamieson merged 3 commits intomcjamieson:feature/add-validation-testsfrom
Conversation
…n to account for worst-case scenario which is single precision, single thread
otbrown
force-pushed
the
add-validation-tests
branch
from
a024c33 to
bca9424
Compare
Author
|
Somehow absolutely butchered this, but all sins will be forgotten come the (squashed) merge commit... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tuned floating-point epsilon to account for worst-case scenario, which is single precision and single thread. Bounds are still reasonably tight for double and quad.
I'll open a separate issue to track the fact that this method performs poorly when using one thread and single precision floating-point on CPU, although I'm not sure there's much to be done about it.