Skip to content

Drop dependency on deprecated gulp-util#10

Closed
Teamop wants to merge 3 commits intomcmath:masterfrom
Teamop:replace-gulp-util
Closed

Drop dependency on deprecated gulp-util#10
Teamop wants to merge 3 commits intomcmath:masterfrom
Teamop:replace-gulp-util

Conversation

@Teamop
Copy link
Copy Markdown

@Teamop Teamop commented Feb 6, 2018

closes #9

@Teamop
Copy link
Copy Markdown
Author

Teamop commented Feb 6, 2018

The Ci passed on Node 8, but it failed on Node 6 and Node 4, after I researched, this issue is related to typescript, right now, the code can just passed on TS 2.4.2, will break on the next versions, so I will just pin the TS to 2.4.2.

Issues got from the Travis CI, which related to params.spec.ts

Issues(partial) TSError: ⨯ Unable to compile TypeScript spec/params.spec.ts (19,36): Value of type '{ (value: T): T; (): undefined; }' has no properties in common with type '{ encoding?: null | undefined; thisArg?: any; }'. Did you mean to call it? (2560) at getOutput (/home/travis/build/mcmath/gulp-transform/node_modules/ts-node/src/index.ts:307:15) at /home/travis/build/mcmath/gulp-transform/node_modules/ts-node/src/index.ts:336:16

@dex4er
Copy link
Copy Markdown

dex4er commented Mar 12, 2018

@mcmath ping?

Copy link
Copy Markdown

@demurgos demurgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just remove @types/plugin-error.

@mcmath
Could we have this merged and published?

package.json Outdated
"@types/lodash": "^4.14.71",
"@types/mocha": "^2.2.41",
"@types/node": "*",
"@types/plugin-error": "^0.1.0",
Copy link
Copy Markdown

@demurgos demurgos Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin-error bundles its own types: no need for the old @types/plugin-error package.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @demurgos, removed

@eduardoconceicao
Copy link
Copy Markdown

@demurgos Can we get this merged?

@demurgos
Copy link
Copy Markdown

I would like to, but I am not a maintainer of this repo.

/cc @mcmath

@Teamop Teamop closed this by deleting the head repository Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated dependency gulp-util

4 participants