Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@Meng-Chau
Copy link

Please don't hesitate to make note of any issues and/or preference changes

Copy link

@KeeyanGhoreshi KeeyanGhoreshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yes/no answers should be booleans and we should try to use valueCoding's whenever we can, strings are not really computable.

]
},
{
"linkId": "6.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The different groups here either need unique linkId's, or they need to be removed and the first entry should just have repeats: true to indicate that you can answer the question multiple times.

},
{
"linkId": "1.12",
"text": "Is there a child in the home or are you a caregiver of small children?",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yes/no questions should be booleans

"type": "choice",
"required": true,
"repeats": true,
"answerOption": [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all of these would be valueCodings instead of strings.

@Meng-Chau Meng-Chau requested a review from KeeyanGhoreshi July 25, 2022 14:50
Copy link

@KeeyanGhoreshi KeeyanGhoreshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a bit of a miscommunication, only use valueCoding where you can. If you don't have a system and a real code beyond copying the display, there's not much reason to use a valueCoding over a string.

Ideally everything would have a code and a system, but some don't. If you're unsure, a quick google search should pull up any codes associated with a keyword.

"answerOption": [
{
"valueString": "A. Adult male with advanced lung cancer; underlying persistent cancer pain managed with 25 mcg/hour transdermal fentanyl patches for the past 2 months"
"valueCoding": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not need to be a valueCoding, it is not something that has a code/codesystem. Moreover, it's a multiple choice assessment style question, there's no reason to have a coding here since we'd only care about the user selecting the correct answer anyway.

This goes for most of the questions in this form.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I see, I initially thought that valueCoding was only for fields that had a code system and corresponding value set, but I noticed that the Turalio forms used valueCoding for arbitrary/custom answer options, and so I just replaced all valueStrings with codings

"answerOption": [
{
"valueString": "MD"
"valueCoding": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are correctly valueCodings, but need their codeSystem in order to be valid: http://www.hl7.org/fhir/v2/0360/2.7/index.html

You can leave "Other" as it is.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would I need to use an extension of sorts to have the code system be registered?

"answerOption": [
{
"valueString": "Morning"
"valueCoding": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a string, though it could also probably be a code I don't think it needs to be since it isn't included as information in any fhir resources.

"answerOption": [
{
"valueString": "Text to Mobile #"
"valueCoding": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be a string

{
"valueString": "Text to Mobile #"
"valueCoding": {
"code": "Text to Mobile #",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the codes for these can be found here: https://build.fhir.org/valueset-contact-point-system.html

@Meng-Chau Meng-Chau requested a review from KeeyanGhoreshi July 26, 2022 13:47
"valueCoding": {
"code": "Text to Mobile #",
"code": "sms",
"system": "http://hl7.org/fhir/ValueSet/contact-point-system",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code system is http://hl7.org/fhir/contact-point-system without the "ValueSet"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how that got in there, but I'll be sure to push that change up

@Meng-Chau Meng-Chau requested a review from KeeyanGhoreshi July 26, 2022 15:48
@smalho01 smalho01 dismissed KeeyanGhoreshi’s stale review August 9, 2022 18:33

approved request

@smalho01 smalho01 merged commit 210305e into master Aug 9, 2022
@smalho01 smalho01 deleted the rems200_TIRF_forms branch November 2, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants