Consolidating log functions from app to RunInstanceLogger

[dmendelowitz]

Summary

checkLogFile and getEffectiveFromDate have been moved from app.js to RunInstanceLogger.js

New behavior

The client should behave the same as before

Code changes

• checkLogFile() and getEffectiveFromDate() have been removed from app.js
• the functionality of checkLogFile has been moved to the constructor of RunInstanceLogger
• getEffectiveFromDate() moved to RunInstanceLogger
• app.js changed to use RunInstanceLogger for these functions
• Tests moved from app.test.js to the new runInstanceLogger.test.js and modified to work with the changes

Testing guidance

• Ensure that the log file functionality still works as before
• Check that the changes to the tests make sense and still pass

[Dtphelan1]

This looks good to me! The one thing this makes me think, however, is that we might want to create super small PR's on other repos to remove their duplicate code and get them to use the RunInstanceLogger for this as well. Let me know what you think about that, or if that's a bit outside the scope of what you were hoping to do for this.

[julianxcarter]

This looks good! I also agree that some companion PRs for the dependent repos would be a good next step if that's not out of scope for this task.

[dmendelowitz]

I had planned to do the companion PRs for the other repos, just wanted to get this merged in first to make things easier. Now that this is approved, I'll get started on those