-
Notifications
You must be signed in to change notification settings - Fork 1
Add RxFill dispense support to PIMS #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR is related to mcode/rems-setup#28 |
|
Overall there is too much logged to the backend. Instead of dumping all of the data structures, just a quick log occasionally as to what is happening or if there is an error would be better. |
|
There is still far too much data being logged, please remove the logging of the entire structures. |
plarocque4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Describe your changes
Issue ticket number and Jira link
https://jira.mitre.org/browse/REMS-595
How to manually test
git checkout rxfillon commit b98825git checkout mainon commit efd4e7<To Qualifier="P">Pharmacy 123</To>Sent RxFill status to EHRappears with the test-ehr endpoint and the response.config.data (RxFill) and response.data (status) contain XML.Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.