Skip to content

Conversation

@jtquach1
Copy link
Contributor

@jtquach1 jtquach1 commented May 21, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

In the PIMS frontend, clicking the "View ETASU" button crashes the page on dev (after version 1.0.0 of pims) if an ETASU element that refers to the auth_number is attempted to be rendered. This PR filters out ETASU elements whose name === 'auth_number', so the checkboxes/x's can render in the modal.

Screenshot of crash:
image

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

N/A, this was randomly discovered.

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

How to manually test this PR

  1. Select Jon Snow & Turalio in request-generator
  2. Send the Rx to PIMS
  3. Go to PIMS frontend at http://localhost:5050/DoctorOrders
  4. Open the Network tab in DevTools
  5. Click the View ETASU button. You will notice the modal renders without a crash, and in the metRequirements network request, the metRequirements list should still contain the object with the auth_number.
  6. Proceed with the rest of the Turalio workflow. The modal should still render with the filled out ETASU.

image

Copy link
Contributor

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't crash for me

@avirgulto avirgulto merged commit 512e0d9 into dev May 22, 2024
@avirgulto avirgulto deleted the auth_number_frontend_crash branch May 22, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants